Skip to content
This repository has been archived by the owner on Jan 12, 2020. It is now read-only.

Benchmarks: added Go, abs2 in mandelbrot, moved plot to front page #647

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Benchmarks: added Go, abs2 in mandelbrot, moved plot to front page #647

merged 2 commits into from
Oct 18, 2017

Conversation

johnfgibson
Copy link
Contributor

@johnfgibson johnfgibson commented Oct 17, 2017

This PR

  • Adds benchmark results from Go
  • Switches to a uniform user-defined function abs2 within the mandelbrot benchmark and renames that userfunc_mandelbrot.
  • Folds in revised results from a small range(t) fix in Python benchmarks JuliaLang/julia#24089
  • Swaps the placement of the benchmark plot (now on front page) and table (now behind a link)
  • Revises front-page text describing the aim of the benchmark, trying to highlight the focus on identical algorithms and code patterns instead of fastest method of computing the result.

<col class="name">
<col class="relative" span="11">
<col class="name"></col>
<col class="relative" span="12"></col>
Copy link
Member

@StefanKarpinski StefanKarpinski Oct 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get these without the </col> – browsers render them in the output? I made that change to Julia master already, so if you rebase your changes, the Perl script that generates this should not include these. Alternatively, you can just edit here.

@ViralBShah
Copy link
Member

Are all the other benchmarks using abs2 uniformly. I only see the julia change in here, and am assuming that we may have needed it in other cases too.

@KristofferC
Copy link
Member

The actual benchmark code is in the Julia repo though, right?

@johnfgibson
Copy link
Contributor Author

@ViralBShah: I'm working on a PR to JuliaLang/julia with the change to abs2 and name userfunc_mandelbrot in all the benchmark codes, probably will file tomorrow.

@ViralBShah
Copy link
Member

Thank you. Forgot for a moment that these are separate repos.

@ChrisRackauckas
Copy link
Member

Anything blocking this?

@StefanKarpinski
Copy link
Member

I wasn't sure if we should merge this before a PR exists for the corresponding code changes, but sure, no harm I guess.

@StefanKarpinski StefanKarpinski merged commit 2674cb7 into JuliaLang:master Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants