Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing check as a Val, because constprop fails. #93

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

chriselrod
Copy link
Contributor

Because checknonsingular is potentially allocating, we need const prop to eliminate the call to be compatible with GPUCompiler codegeneration/static compilation.

@chriselrod chriselrod requested a review from YingboMa April 10, 2024 19:28
@YingboMa YingboMa merged commit 26de024 into master Apr 11, 2024
13 checks passed
@YingboMa YingboMa deleted the checkdoesnotconstprop branch April 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants