Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use square_view to avoid square check, instead of new hack #94

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Use square_view to avoid square check, instead of new hack #94

merged 2 commits into from
Apr 16, 2024

Conversation

chriselrod
Copy link
Contributor

This also switches to TriangularSolve@0.2, which doesn't use any internal buffers, increasing the static-compileability of RecursiveFactorization.

@chriselrod chriselrod requested a review from YingboMa April 15, 2024 16:33
@chriselrod
Copy link
Contributor Author

I also bumped the Julia version requirement to 1.10.

@YingboMa YingboMa merged commit 3cb6959 into master Apr 16, 2024
7 checks passed
@YingboMa YingboMa deleted the square_view branch April 16, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YingboMa YingboMa YingboMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselrod @YingboMa