Set allocatetmp=false by default

Better to be safe than optimized

src/symwoodbury.jl

@@ -13,7 +13,7 @@ struct SymWoodbury{T,AType,BType,DType,DpType} <: AbstractWoodbury{T}
 end
 
 """
-    W = SymWoodbury(A, B, D; allocatetmp::Bool=true)
+    W = SymWoodbury(A, B, D; allocatetmp::Bool=false)
 
 Represent a matrix of the form `W = A + BDBᵀ`, where `A` and `D` are symmetric.
 Equations `Wx = b` will be solved using the
@@ -28,7 +28,7 @@ or factorization.
 
 See also [Woodbury](@ref), where `allocatetmp` is explained.
 """
-function SymWoodbury(A, B::AbstractVecOrMat, D; allocatetmp::Bool=true)
+function SymWoodbury(A, B::AbstractVecOrMat, D; allocatetmp::Bool=false)
     @noinline throwdmm(B, D, A) = throw(DimensionMismatch("Sizes of B ($(size(B))) and/or D ($(size(D))) are inconsistent with A ($(size(A)))"))
 
     n = size(A, 1)

src/woodbury.jl

@@ -14,7 +14,7 @@ struct Woodbury{T,AType,UType,VType,CType,CpType} <: AbstractWoodbury{T}
 end
 
 """
-    W = Woodbury(A, U, C, V; allocatetmp::Bool=true)
+    W = Woodbury(A, U, C, V; allocatetmp::Bool=false)
 
 Represent a matrix `W = A + UCV`.
 Equations `Wx = b` will be solved using the
@@ -27,14 +27,14 @@ If `allocatetmp` is true, temporary storage used for intermediate steps in
 multiplication and division will be allocated.
 
 !!! warning
-    If you'll use the same `W` in multiple threads, you should set `allocatetmp=false`
+    If you'll use the same `W` in multiple threads, you should use `allocatetmp=false`
     or risk data races.
 
 
 See also [SymWoodbury](@ref).
 
 """
-function Woodbury(A, U::AbstractMatrix, C, V::AbstractMatrix; allocatetmp::Bool=true)
+function Woodbury(A, U::AbstractMatrix, C, V::AbstractMatrix; allocatetmp::Bool=false)
     @noinline throwdmm1(U, V, A) = throw(DimensionMismatch("Sizes of U ($(size(U))) and/or V ($(size(V))) are inconsistent with A ($(size(A)))"))
     @noinline throwdmm2(k) = throw(DimensionMismatch("C should be $(k)x$(k)"))
 

test/symwoodbury.jl

@@ -26,7 +26,7 @@ for elty in (Float32, Float64, ComplexF32, ComplexF64, Int)
     ε = eps(abs2(float(one(elty))))
     A = Diagonal(a)
 
-    for W in (SymWoodbury(A, B, D), SymWoodbury(A, B, D; allocatetmp=false), SymWoodbury(A, B[:,1][:], 2.))
+    for W in (SymWoodbury(A, B, D), SymWoodbury(A, B, D; allocatetmp=true), SymWoodbury(A, B[:,1][:], 2.))
 
         @test issymmetric(W)
         F = Matrix(W)

test/woodbury.jl

@@ -39,7 +39,7 @@ for elty in (Float32, Float64, ComplexF32, ComplexF64, Int)
     T = Tridiagonal(dl, d, du)
 
     # Matrix for A
-    for W in (Woodbury(T, U, C, V), Woodbury(T, U, C, V; allocatetmp=false))
+    for W in (Woodbury(T, U, C, V), Woodbury(T, U, C, V; allocatetmp=true))
         @test size(W, 1) == n
         @test size(W) == (n, n)
         @test axes(W) === (Base.OneTo(n), Base.OneTo(n))