Use the properly-capitalized C-ABI MKL threading interface #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the all-lowercase threading symbols are actually all
FORTRAN ABI, as can be seen through `dlsym()`:
```
julia> dlsym(libmkl_rt, "mkl_set_num_threads")
Ptr{Nothing} @0x00007fa64f24e3b0
julia> dlsym(libmkl_rt, "mkl_set_num_threads_")
Ptr{Nothing} @0x00007fa64f24e3b0
```
The C-ABI versions are not the non-underscore-suffixed ones, but the
capitalized ones, e.g. `MKL_Set_Num_Threads`. The more you know.
|
Should fix JuliaLinearAlgebra/MKL.jl#67 |
|
Is it worth adding a test here? |
|
Not really... |
|
The issue is that the only way to test it is to segfault. :( |
|
Can leave a comment in the code. |
I thought that was easy to achieve with this library 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the all-lowercase threading symbols are actually all
FORTRAN ABI, as can be seen through
dlsym():The C-ABI versions are not the non-underscore-suffixed ones, but the
capitalized ones, e.g.
MKL_Set_Num_Threads. The more you know.