Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly identify OS when cross compile with MinGW on Linux #79

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Correctly identify OS when cross compile with MinGW on Linux #79

merged 2 commits into from
Jun 16, 2022

Conversation

metab0t
Copy link
Contributor

@metab0t metab0t commented Jun 15, 2022

No description provided.

@staticfloat
Copy link
Member

I'd prefer not to make assumptions based on the name of $(CC). If you want to auto-support this, we should parse the output of $(CC) -dumpmachine.

@metab0t
Copy link
Contributor Author

metab0t commented Jun 16, 2022

I'd prefer not to make assumptions based on the name of $(CC). If you want to auto-support this, we should parse the output of $(CC) -dumpmachine.

Thanks for suggestion. Changes applied.

@staticfloat staticfloat merged commit ab5a124 into JuliaLinearAlgebra:main Jun 16, 2022
@metab0t metab0t deleted the patch-3 branch June 16, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metab0t @staticfloat