Fix composition of f2c and complex return style in Apple Accelerate #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the SO version should be bumped to 5.0.3? |
With the new complex return style code in 0829248, we don't need to do this work, and indeed when we do it twice, Accelerate breaks on x86_64 macOS.
staticfloat
force-pushed
the
sf/f2c_complexret_composition
branch
from
ab93661 to
3b4c984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added complex return style detection in #61 I failed to test it on an f2c BLAS such as Apple Accelerate, where I would have noticed that we were already applying a similar workaround there. This cleanly separates the two concerns, and fixes macOS testing, which would have showcased the problem immediately.