Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DemuxLogger for TeeLogger, that does not support include_current_global kwarg #22

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

oxinabox
Copy link
Member

When looking at #20 I realized that including the current global logger often is not desired.
Since the default ConsoleLogger that comes with the REPL is not a pure sink,
and so one might prefer to instead point at a new ConsoleLogger(stderr, BelowMinLevel())

Plus the kwarg is longer than the function call,
plus in a deep compositional structure only at most one level would want that, so bad to default to true.

Deprecating that behavour out is hard, but deprecating to use a different logger with a new name is easy, and we wanted to change the name anyway.

Closes #1 by renaming DemuxLogger
Closes #11 by removing kwargs that interact with the global_logger

@c42f do you approve of the name? Was your suggestion originally,
or should we go for MultiLogger?

@codecov-io
Copy link

Codecov Report

Merging #22 into master will decrease coverage by 1.38%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   80.32%   78.94%   -1.39%     
==========================================
  Files           7        7              
  Lines          61       57       -4     
==========================================
- Hits           49       45       -4     
  Misses         12       12
Impacted Files Coverage Δ
src/LoggingExtras.jl 100% <ø> (ø) ⬆️
src/tee.jl 87.5% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb19b17...fd2328c. Read the comment docs.

@c42f
Copy link
Member

c42f commented Oct 24, 2019

I'm fine with the name TeeLogger, but neither do I really love it in the sense that I can't yet see it's an "obviously right" consistent and clear choice :-)

@c42f c42f mentioned this pull request Oct 24, 2019
@oxinabox
Copy link
Member Author

I am going to merge this and leave the issue open.

@oxinabox oxinabox merged commit 19d4071 into master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current_logger and global_logger Change name from TeeLogger?
3 participants