Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: cover LIBLINEAR usage #100

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

barucden
Copy link
Member

I verified that the added test errors with LIBLINEARv0.6. With LIBLINEARv0.7, the test passes.

Curiously, LIBLINEAR is only used when fitting LinearSVC through the "scikit" API (never through svmtrain/svmpredict).

Resolves #98

I verified that the added test errors with LIBLINEARv0.6. With
LIBLINEARv0.7, the test passes.

Curiously, LIBLINEAR is only used when fitting LinearSVC through the
"scikit" API (never through `svmtrain`/`svmpredict`).

Resolves JuliaML#98
Copy link
Contributor

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@barucden barucden merged commit 1ce6283 into JuliaML:master Apr 19, 2024
6 checks passed
@barucden barucden deleted the linearsvc-test branch April 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug?
2 participants