Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change MNIST download links #58

Merged
merged 2 commits into from
Mar 30, 2021
Merged

change MNIST download links #58

merged 2 commits into from
Mar 30, 2021

Conversation

CarloLucibello
Copy link
Member

Fix #57 using the mirror offered by pytorch vision (pytorch/vision#3544)

@johnnychen94

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good fix to me.

Eventually, I want to switch to Artifacts based to take advantage of Julia's Pkg/Storage server; users in China usually have difficulties connecting to aws s3... but have good connection to Julia Pkg mirrors (e.g., BFSU).

@CarloLucibello
Copy link
Member Author

switching to artifacts would be good, we have to find some hosting service though

@johnnychen94
Copy link
Member

we have to find some hosting service though

Github releases :P https://github.com/JuliaML/MLDatasets.jl/releases/tag/v0.6.0-datasets

@codecov-io
Copy link

Codecov Report

Merging #58 (176dedc) into master (89fb38b) will decrease coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   11.18%   10.16%   -1.03%     
==========================================
  Files          27       26       -1     
  Lines         626      620       -6     
==========================================
- Hits           70       63       -7     
- Misses        556      557       +1     
Impacted Files Coverage Δ
src/MNIST/MNIST.jl 66.66% <ø> (-8.34%) ⬇️
src/CIFAR10/CIFAR10.jl 50.00% <0.00%> (-10.00%) ⬇️
src/SVHN2/SVHN2.jl 66.66% <0.00%> (-8.34%) ⬇️
src/CIFAR100/CIFAR100.jl 66.66% <0.00%> (-8.34%) ⬇️
src/FashionMNIST/FashionMNIST.jl 66.66% <0.00%> (-8.34%) ⬇️
src/download.jl 0.00% <0.00%> (-3.23%) ⬇️
src/MNIST/Reader/Reader.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89fb38b...176dedc. Read the comment docs.

@CarloLucibello CarloLucibello merged commit 4b472b9 into master Mar 30, 2021
@johnnychen94 johnnychen94 deleted the cl/mnist branch March 30, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot download MNIST
3 participants