This repository has been archived by the owner on May 21, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Speed part 3 #13
Open
JobJob
wants to merge
13
commits into
JuliaML:master
Choose a base branch
from
JobJob:speedierer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Speed part 3 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus: * update abstract type syntax for 0.6+ * remove a non-universal linux workaround
AFAICT Universe is not maintained by OpenAI anymore, and should probably have it's own file/project anyway to reduce clutter
This was referenced Sep 15, 2018
And improve test output formatting
oopsie daisy : D - was quite broken without this
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
unsafe_gettpl!
from JuliaPy/PyCall.jl#486 to get faster access to the elements from thes, r, done, info
tuple returned by gymenv.step
functions in Python.This is two extra commits on top of #12
Requires
You can test this out by checking out the
dev
branch on https://github.com/JobJob/PyCall.jl, and thefixes-for-1.0
branch for https://github.com/JobJob/Reinforce.jl, and the branch for this PR -speedierer
on https://github.com/JobJob/OpenAIGym.jlThere may be some artifacts in the timing, but speed of stepping the environments in a loop (with random actions) seems slightly faster in Julia than Python for all envs.
Here's the performance vs Python 3 on my machine using the Julia and Python benchmarks the tests: