Trying to fix FiniteDifferences + SArray failure (#729)

* Trying to fix FiniteDifferences + SArray failure * bump ambiguities :(
JuliaManifolds · Jun 12, 2024 · 8602529 · 8602529
1 parent b0008c0
commit 8602529
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/manifolds/MetricManifold.jl b/src/manifolds/MetricManifold.jl
@@ -487,7 +487,7 @@ function local_metric_jacobian(
     backend::AbstractDiffBackend=default_differential_backend(),
 )
     n = size(p, 1)
-    ∂g = reshape(_jacobian(q -> local_metric(M, q, B), p, backend), n, n, n)
+    ∂g = reshape(_jacobian(q -> local_metric(M, q, B), copy(M, p), backend), n, n, n)
     return ∂g
 end
 @trait_function local_metric_jacobian(

diff --git a/test/ambiguities.jl b/test/ambiguities.jl
@@ -17,7 +17,7 @@ end
         # Interims solution until we follow what was proposed in
         # https://discourse.julialang.org/t/avoid-ambiguities-with-individual-number-element-identity/62465/2
         fmbs = filter(x -> !any(has_type_in_signature.(x, Identity)), mbs)
-        FMBS_LIMIT = 34
+        FMBS_LIMIT = 38
         println("Number of ManifoldsBase.jl ambiguities: $(length(fmbs))")
         @test length(fmbs) <= FMBS_LIMIT
         if length(fmbs) > FMBS_LIMIT
@@ -30,7 +30,7 @@ end
         # Interims solution until we follow what was proposed in
         # https://discourse.julialang.org/t/avoid-ambiguities-with-individual-number-element-identity/62465/2
         fms = filter(x -> !any(has_type_in_signature.(x, Identity)), ms)
-        FMS_LIMIT = 47
+        FMS_LIMIT = 53
         println("Number of Manifolds.jl ambiguities: $(length(fms))")
         if length(fms) > FMS_LIMIT
             for amb in fms