Fix defaults on Grassmann #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 98 98
Lines 9894 9897 +3
=======================================
+ Hits 9786 9789 +3
Misses 108 108
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Good idea. Manopt tests are failing because it defines |
|
That is also done in the same branch linked above. |
|
Ah I will document the new defaults for sure so they should up in the docs. |
kellertuer
added
the
Ready-for-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main reason – it defaulted to exp/parallel transport, which do not exist in Stiefel representation.