Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand for GL and Heisenberg group #610

Merged
merged 9 commits into from
May 22, 2023
Merged

rand for GL and Heisenberg group #610

merged 9 commits into from
May 22, 2023

Conversation

mateuszbaran
Copy link
Member

Useful for testing here: #609 .

@mateuszbaran mateuszbaran added extend manifold This issue proposes/asks for new functions to extend an existing manifold Ready-for-Review A label for pull requests that are feature-ready labels May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #610 (7cc5c2b) into master (133eef8) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   98.92%   99.01%   +0.09%     
==========================================
  Files         102      102              
  Lines       10007    10034      +27     
==========================================
+ Hits         9899     9935      +36     
+ Misses        108       99       -9     
Impacted Files Coverage Δ
src/groups/general_linear.jl 99.09% <100.00%> (+0.05%) ⬆️
src/groups/heisenberg.jl 100.00% <100.00%> (ø)
src/groups/semidirect_product_group.jl 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only remark for this PR is (the typical Ronny-one), that both new rand methods should be documented.

@mateuszbaran
Copy link
Member Author

I was actually somewhat expecting another long discussion whether this is the right distribution 😅

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one typo, this looks good to me.

src/groups/general_linear.jl Outdated Show resolved Hide resolved
@mateuszbaran mateuszbaran merged commit 978e017 into master May 22, 2023
@kellertuer kellertuer deleted the mbaran/rand-group branch May 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extend manifold This issue proposes/asks for new functions to extend an existing manifold Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants