Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #613 #614

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix #613 #614

merged 2 commits into from
May 24, 2023

Conversation

kellertuer
Copy link
Member

This resolves #613

The problem was that if is_point returned true and te was false, the is_vector already returned true without checking the vector.

Now it correctly

  1. Throws an error if the point check fails and te=true (not done before)
  2. returns false if the point check fails and te=false
  3. continues to checking the vector (as opposed to before) if the point check passes.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #614 (4601558) into master (b515345) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   99.00%   98.98%   -0.03%     
==========================================
  Files         104      104              
  Lines       10034    10033       -1     
==========================================
- Hits         9934     9931       -3     
- Misses        100      102       +2     
Impacted Files Coverage Δ
src/groups/group.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label May 24, 2023
Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kellertuer kellertuer merged commit 47d1270 into master May 24, 2023
@kellertuer kellertuer deleted the kellertuer/fix613 branch May 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing behaviour of is_vector
2 participants