Deprecate LinearAffineMetric, resolves #527 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use AffineInvairantMetric instead.
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 98.99% 99.00%
=======================================
Files 104 104
Lines 10033 10033
=======================================
+ Hits 9932 9933 +1
+ Misses 101 100 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…d version warns – at least not between 1.6, 1.8 _and_ 1.9 – just check that the old still works.
kellertuer
added
the
Ready-for-Review
mateuszbaran
added
the
preview docs
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
mateuszbaran
approved these changes
May 29, 2023
|
Thanks for the careful revision and help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
AffineInvariantMetricinstead. This resolves #527.I am just not sure the deprecation tests work, it seems one can check for a warning (if tests are run with
depwarn=trueor use `@test_deprecated´ but I can consistently get both to pass and fail. So let's see what the CI likes.