Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #199 #200

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix #199 #200

merged 2 commits into from
Aug 11, 2024

Conversation

kellertuer
Copy link
Member

This fixes get_vectors to work also on power manifolds of product manifolds.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (1bf8149) to head (07716e7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          31       31           
  Lines        3294     3294           
=======================================
  Hits         3291     3291           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test but otherwise LGTM.

@kellertuer
Copy link
Member Author

Sure, I will add that tomorrow.

@kellertuer kellertuer merged commit 8469ef9 into master Aug 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants