Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix digits buffer for Julia 1.1 #84

Merged
merged 1 commit into from
Dec 14, 2018
Merged

fix digits buffer for Julia 1.1 #84

merged 1 commit into from
Dec 14, 2018

Conversation

stevengj
Copy link
Member

Fixes compatibility with Julia 1.1 as commented JuliaLang/julia#30374 (comment) and JuliaLang/julia#30373 (comment), due to recent changes in Julia printf internals.

cc @JeffBezanson

@stevengj stevengj mentioned this pull request Dec 14, 2018
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 160

  • 9 of 14 (64.29%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.9%) to 90.417%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DecFP.jl 9 14 64.29%
Files with Coverage Reduction New Missed Lines %
src/DecFP.jl 13 89.67%
Totals Coverage Status
Change from base Build 156: -3.9%
Covered Lines: 217
Relevant Lines: 240
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Dec 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 160

  • 9 of 14 (64.29%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.9%) to 90.417%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DecFP.jl 9 14 64.29%
Files with Coverage Reduction New Missed Lines %
src/DecFP.jl 13 89.67%
Totals Coverage Status
Change from base Build 156: -3.9%
Covered Lines: 217
Relevant Lines: 240
💛 - Coveralls

@stevengj
Copy link
Member Author

64-bit appveyor failure on 0.6 is not a regression.

@stevengj stevengj merged commit ad5f8ad into master Dec 14, 2018
@stevengj stevengj deleted the digitsbuf branch December 14, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevengj @coveralls