-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reduction machinery for 0.7 #100
Conversation
The promotion machinery for reduction in sum/prod was changed in JuliaLang/julia#25051. This updates the use.
f9c9e51
to
99e5409
Compare
test/runtests.jl
Outdated
@@ -1,6 +1,8 @@ | |||
using FixedPointNumbers, Base.Test | |||
|
|||
@test isempty(detect_ambiguities(FixedPointNumbers, Base, Core)) | |||
if VERSION < v"0.7.0-" | |||
@test isempty(detect_ambiguities(FixedPointNumbers, Base, Core)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab here
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 93.33% 91.44% -1.89%
==========================================
Files 4 4
Lines 180 187 +7
==========================================
+ Hits 168 171 +3
- Misses 12 16 +4
Continue to review full report at Codecov.
|
99e5409
to
539ab20
Compare
I've defined a few methods to resolve some ambiguities |
539ab20
to
f0c718b
Compare
Thanks folks! |
The promotion machinery for reduction in sum/prod was changed in JuliaLang/julia#25051. This updates the use.