Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reduction machinery for 0.7 #100

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Update reduction machinery for 0.7 #100

merged 2 commits into from
Feb 1, 2018

Conversation

simonbyrne
Copy link
Member

The promotion machinery for reduction in sum/prod was changed in JuliaLang/julia#25051. This updates the use.

The promotion machinery for reduction in sum/prod was changed in JuliaLang/julia#25051. This updates the use.
test/runtests.jl Outdated
@@ -1,6 +1,8 @@
using FixedPointNumbers, Base.Test

@test isempty(detect_ambiguities(FixedPointNumbers, Base, Core))
if VERSION < v"0.7.0-"
@test isempty(detect_ambiguities(FixedPointNumbers, Base, Core))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab here

@codecov-io
Copy link

codecov-io commented Jan 31, 2018

Codecov Report

Merging #100 into master will decrease coverage by 1.88%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   93.33%   91.44%   -1.89%     
==========================================
  Files           4        4              
  Lines         180      187       +7     
==========================================
+ Hits          168      171       +3     
- Misses         12       16       +4
Impacted Files Coverage Δ
src/fixed.jl 100% <100%> (ø) ⬆️
src/normed.jl 97.67% <100%> (+0.02%) ⬆️
src/FixedPointNumbers.jl 90.27% <50%> (-5.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8aee8...f0c718b. Read the comment docs.

@andreasnoack
Copy link
Member

andreasnoack commented Jan 31, 2018

I've defined a few methods to resolve some ambiguities and then I've marked a few printing methods as broken to get this one ready. There are still some ambiguities as reported in #101 but I think we should merge this as is and then resolve the ambiguities later since this is blocking work other packages.

@timholy timholy merged commit 25affc6 into master Feb 1, 2018
@timholy timholy deleted the sb/promote branch February 1, 2018 02:24
@timholy
Copy link
Member

timholy commented Feb 1, 2018

Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants