Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete specialized show methods for types #11

Merged
merged 1 commit into from
Sep 2, 2014
Merged

Delete specialized show methods for types #11

merged 1 commit into from
Sep 2, 2014

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 25, 2014

Earlier incarnations caused troubles, and it was recommended (see issue #9)
to drop these.

See also JuliaAttic/Color.jl@fc94af2

Earlier incarnations caused troubles, and it was recommended (see issue #9)
to drop these.
@timholy
Copy link
Member Author

timholy commented Sep 1, 2014

Bump

JeffBezanson added a commit that referenced this pull request Sep 2, 2014
Delete specialized show methods for types
@JeffBezanson JeffBezanson merged commit 5a5187f into JuliaMath:master Sep 2, 2014
@timholy
Copy link
Member Author

timholy commented Sep 2, 2014

Thanks for getting to this.

@timholy timholy deleted the pull-request/33a9d93f branch April 22, 2020 16:03
timholy added a commit to JuliaGeometry/GeometryBasics.jl that referenced this pull request Jul 1, 2020
Overloading `show` for types is strongly discouraged. I'm currently tracking down a Julia segfault that's caused by this line.

Refs:
- JuliaMath/FixedPointNumbers.jl#11
- PainterQubits/Unitful.jl#321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants