Use OpenLibm explicitly, to prepare for its excision from base. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 77.07% 81.44% +4.37%
==========================================
Files 6 7 +1
Lines 1086 1105 +19
==========================================
+ Hits 837 900 +63
+ Misses 249 205 -44
Continue to review full report at Codecov.
|
ararslan
approved these changes
Jul 14, 2022
|
@giordano If I am changing the compat for julia from 1 to 1.3, what do I need to do with the version number bump? |
|
Patch bump should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for JuliaLang/julia#42299. Eventually, we will remove OpenLibm_jll from base altogether, but having OpenLibm_jll in the Project.toml will ensure that things do not break.
Add 32-bit platforms to the CI.
Bump julia compat to 1.3, since that's what we need for OpenLibm_jll.