Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support union of multiple intervals #156

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions src/interval.jl
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,36 @@ end

intersect(d1::AbstractInterval, d2::AbstractInterval) = intersect(Interval(d1), Interval(d2))

union(I::TypedEndpointsInterval...) = unioninterval(intervalunion!([I...]))
unioninterval(x) = isone(length(x)) ? x[1] : throw(ArgumentError("Cannot construct union of disjoint sets."))
function intervalunion!(I::Vector{<:TypedEndpointsInterval})
sort!(I, by = leftendpoint)

# filter out empty sets
k = 1
while k <= length(I)
if isempty(I[k])
popat!(I,k)
else
k += 1
end
end

function union(d1::TypedEndpointsInterval{L1,R1,T1}, d2::TypedEndpointsInterval{L2,R2,T2}) where {L1,R1,T1,L2,R2,T2}
T = promote_type(T1,T2)
isempty(d1) && return Interval{L2,R2,T}(d2)
isempty(d2) && return Interval{L1,R1,T}(d1)
any(∈(d1), endpoints(d2)) || any(∈(d2), endpoints(d1)) ||
throw(ArgumentError("Cannot construct union of disjoint sets."))
_union(d1, d2)
# merge intervals
k = 2
while k <= length(I)
x = leftendpoint(I[k])
y = rightendpoint(I[k-1])
if x > y
k += 1
elseif x < y || x ∈ I[k] || x ∈ I[k-1]
I[k-1] = _union(I[k-1],I[k])
popat!(I,k)
else
k += 1
end
end
I
end

# these assume overlap
Expand Down
4 changes: 4 additions & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,10 @@ struct IncompleteInterval <: AbstractInterval{Int} end
i5 = nextfloat(one(T)) .. 2one(T)
i_empty = one(T) ..zero(T)

# - union of multiple intervals
# issue #103
@test i1 ∪ i2 ∪ i3 ∪ i4 ∪ i5 ∪ i_empty == 0..3
putianyi889 marked this conversation as resolved.
Show resolved Hide resolved

# - union of completely overlapping intervals
# i1 0 ------>------ 1
# i2 1/3 ->- 1/2
Expand Down