move [l]gamma, [l]beta and lfact from base #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Jun 11, 2018
src/gamma.jl
Outdated
| @@ -539,3 +539,228 @@ function polygamma(m::Integer, z::Number) | |||
| # There is nothing to fallback to, since this didn't work | |||
| polygamma(m, x) | |||
| end | |||
|
|
|||
| @static if true # VERSION >= v"something" | |||
There was a problem hiding this comment.
Thanks, will update this tonight
vtjnash
reviewed
Jun 11, 2018
src/gamma.jl
Outdated
| return z | ||
| end | ||
|
|
||
| lgamma_r(x::BigFloat) = (lgamma(x), lgamma_signp[]) |
There was a problem hiding this comment.
Corrected version of this (from JuliaLang/julia#27331):
# log of absolute value of gamma function
function lgamma_r(x::BigFloat)
z = BigFloat()
lgamma_signp = Ref{Cint}()
ccall((:mpfr_lgamma,:libmpfr), Cint, (Ref{BigFloat}, Ref{Cint}, Ref{BigFloat}, Int32), z, lgamma_signp, x, ROUNDING_MODE[])
return z, lgamma_signp[]
end
lgamma(x::BigFloat) = lgamma_r(x)[1]Commit message: "Switch to allocating lgamma_sign on the stack, for better performance (and thread-safety)"
deprecate lfact to lfactorial
… (and thread-safety).
vtjnash
reviewed
Jun 24, 2018
| function gamma(x::BigFloat) | ||
| isnan(x) && return x | ||
| z = BigFloat() | ||
| ccall((:mpfr_lgamma, :libmpfr), Int32, (Ref{BigFloat}, Ref{BigFloat}, Int32), z, x, ROUNDING_MODE[]) |
szcf-weiya
added a commit
to szcf-weiya/SpecialFunctions.jl
that referenced
this pull request
Aug 26, 2018
`[l]gamma`, `[l]beta` and `lfact` have been moved to this module from `base` module (JuliaMath#92 ), but the docs have not been updated yet. I added their docs from [Docs for Julia v0.6.1](https://docs.julialang.org/en/v0.6.1/manual/mathematical-operations/#Special-functions-1).
simonbyrne
pushed a commit
that referenced
this pull request
Sep 13, 2018
* docs for `[l]gamma`, `[l]beta` and `lfact` `[l]gamma`, `[l]beta` and `lfact` have been moved to this module from `base` module (#92 ), but the docs have not been updated yet. I added their docs from [Docs for Julia v0.6.1](https://docs.julialang.org/en/v0.6.1/manual/mathematical-operations/#Special-functions-1). * Update index.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #27473