-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a Glue Type / N-Body Empirical Potential - the Finnis-Sinclair 1984 potential for single element systems #32
base: master
Are you sure you want to change the base?
Changes from 15 commits
19f43d6
a3f4b6a
5b805ff
8942490
87e7d82
52f46b8
dd0881c
221b690
eaacf33
a9d7ef1
fd93544
95b9635
36457e0
1808489
057b9a6
acf7ce8
b99aca3
fd7cb6f
f80004e
275c296
b136903
931f214
4e2c73b
f88c5b2
3982887
b472fd9
ee4d487
5a81002
c0d37fa
a71dc51
4b55ae4
b332f60
825f1ad
d646f9b
945ddb0
115adf2
30a54b2
331cc70
d87b4c6
bbc47f1
d073ef8
fbf2629
d95cfbe
b276156
71522fe
b9ece8d
d1f113a
05d1990
12c5a31
996ed6e
3b9ce51
076ad3d
d2b3375
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,17 +8,15 @@ BioStructures = "de9282ab-8554-53be-b2d6-f6c222edabfc" | |
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba" | ||
Colors = "5ae59095-9a9b-59fe-a467-6f913c188581" | ||
Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7" | ||
Crystal = "3c6eccdf-2a89-4c24-a1d4-ff210daa8476" | ||
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0" | ||
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f" | ||
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210" | ||
KernelDensity = "5ab0869b-81aa-558d-bb23-cbf5423bbe9b" | ||
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | ||
NearestNeighbors = "b8a86587-4115-5ab1-83bc-aa920d37bbce" | ||
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" | ||
ProgressMeter = "92933f4c-e287-5a05-a399-4b506db050ca" | ||
Reexport = "189a3867-3050-52da-a836-e630ba90ab69" | ||
Requires = "ae029012-a4dd-5104-9daa-d747884805df" | ||
SingleCrystal = "3c6eccdf-2a89-4c24-a1d4-ff210daa8476" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, thanks, should be fixed, as soon as I push my changes. |
||
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" | ||
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | ||
|
||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,6 +1,10 @@ | ||||||
[deps] | ||||||
Crystal = "3c6eccdf-2a89-4c24-a1d4-ff210daa8476" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be
Suggested change
|
||||||
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0" | ||||||
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||||||
Molly = "aa0f7f06-fcc0-5ec4-a7f3-a573f33f9c4c" | ||||||
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The plots in the documentation could be generated during the docs build, but it would be ideal to use the same package for all the plots (preferably one of the Makie backends). @jgreener64 One idea would be to use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would indeed be better to use the same plotting package throughout, though at the minute the code in the docs is not run during the docs build and Makie plots are pasted as images into the doc files. It would be good if the docs notebook appeared in the docs - perhaps it could go in the examples section as markdown. Then these docs dependencies can be removed until we deal with doctests later, as the examples can assume that users have the package installed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tried using |
||||||
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||||||
|
||||||
[compat] | ||||||
Documenter = "0.25" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a need to use
ForwardDiff
for the derivatives introduced by this change. The derivatives expressions could be derived analytically and used directly. This might also be slightly more performant than doing them numerically.