Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make frule usable by ForwardDiff #6

Merged
merged 6 commits into from
Mar 9, 2022
Merged

[WIP] Make frule usable by ForwardDiff #6

merged 6 commits into from
Mar 9, 2022

Conversation

mohamed82008
Copy link
Member

This PR enables selectively supporting some frules from ChainRules in ForwardDiff. I still need to test functions with struct inputs and outputs.

@codecov-commenter
Copy link

Codecov Report

Merging #6 (baa30f8) into main (6d5b806) will increase coverage by 2.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   85.51%   87.57%   +2.05%     
==========================================
  Files           1        1              
  Lines         145      169      +24     
==========================================
+ Hits          124      148      +24     
  Misses         21       21              
Impacted Files Coverage Δ
src/NonconvexUtils.jl 87.57% <100.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d5b806...baa30f8. Read the comment docs.

@mohamed82008
Copy link
Member Author

As soon as NonconvexCore 1.0.2 is released, tests here should pass and I will merge and release it soon after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants