Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Test Dependency without extensions #167

Closed
wants to merge 1 commit into from

Conversation

nhz2
Copy link

@nhz2 nhz2 commented Aug 29, 2024

This PR replaces the use of Test.@test with ArgCheck.@argcheck to improve loading times by about 20 ms.

Here are some basic timings.

Master:

julia> @time_imports import Accessors
      6.4 ms  MacroTools
               ┌ 0.0 ms InverseFunctions.__init__() 
     21.5 ms  InverseFunctions 89.30% compilation time
      0.1 ms  InverseFunctions → InverseFunctionsDatesExt
      0.2 ms  ConstructionBase
      0.1 ms  CompositionsBase
      0.1 ms  CompositionsBase → CompositionsBaseInverseFunctionsExt
     18.3 ms  Test
      0.1 ms  InverseFunctions → InverseFunctionsTestExt
               ┌ 0.0 ms Accessors.__init__() 
      8.6 ms  Accessors

This PR:

julia> @time_imports import Accessors
      6.0 ms  MacroTools
               ┌ 0.0 ms InverseFunctions.__init__() 
     21.1 ms  InverseFunctions 89.71% compilation time
      0.1 ms  InverseFunctions → InverseFunctionsDatesExt
      0.3 ms  ConstructionBase
      0.1 ms  CompositionsBase
      0.1 ms  CompositionsBase → CompositionsBaseInverseFunctionsExt
      0.4 ms  ArgCheck
               ┌ 0.0 ms Accessors.__init__() 
      9.0 ms  Accessors

From what I can tell

function test_getset_laws end
function test_modify_law end
function test_getsetall_laws end
function test_insertdelete_laws end

are all not documented, so changing them should not be a breaking change.

@aplavin
Copy link
Member

aplavin commented Sep 13, 2024

#168 is merged

@aplavin aplavin closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants