Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #72 #75

Merged
merged 4 commits into from
Feb 23, 2023
Merged

fix #72 #75

merged 4 commits into from
Feb 23, 2023

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Feb 23, 2023

Cleaner than #74: @generated isn't actually needed here anymore, Julia internals aren't accessed.
We only use @generated here because of 1.6 and earlier: #60 (comment).
After those versions stop being relevant, the if branch can be just removed.

All tests, including downstream and timing, pass.

@jw3126
Copy link
Member

jw3126 commented Feb 23, 2023

Awesome, can you bump the patch version?

src/ConstructionBase.jl Outdated Show resolved Hide resolved
@aplavin
Copy link
Member Author

aplavin commented Feb 23, 2023

Bumped. But 1.5.0 isn't registered yet anyway...

@jw3126
Copy link
Member

jw3126 commented Feb 23, 2023

Ok sry 1.5.0 is fine then.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Base: 34.05% // Head: 35.46% // Increases project coverage by +1.40% 🎉

Coverage data is based on head (5f08dd3) compared to base (4d661f8).
Patch coverage: 66.66% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   34.05%   35.46%   +1.40%     
==========================================
  Files           5        5              
  Lines         138      141       +3     
==========================================
+ Hits           47       50       +3     
  Misses         91       91              
Impacted Files Coverage Δ
src/ConstructionBase.jl 52.63% <66.66%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jw3126 jw3126 merged commit 83d75ce into JuliaObjects:master Feb 23, 2023
@aplavin aplavin deleted the fix72 branch February 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants