Make LinearAlgebra a weak dependency #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstructionBase doesn't depend on anything (apart from LinearAlgebra currently), so it can't trigger the circular dependency issue. It's completely safe to make LinearAlgebra a weak dependency on all Julia versions that support weak dependencies.
On the contrary, if ConstructionBase keeps LinearAlgebra as a direct dependency, then packages that depend on ConstructionBase and decide to make LinearAlgebra a weak dependency (e.g. Accessors) will run into the circular dependency issue. So a direct dependency on LinearAlgebra in ConstructionBase holds back large parts of the ecosystem.