Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimization for discrete uniform distributions of equal size #17

Merged
merged 5 commits into from
Dec 21, 2021

Conversation

devmotion
Copy link
Member

Adds an optimization in the case of discrete uniform distributions of the same size.

test/exact.jl Outdated Show resolved Hide resolved
devmotion and others added 3 commits December 21, 2021 01:00
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Dec 21, 2021

Pull Request Test Coverage Report for Build 1604642274

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 97.006%

Totals Coverage Status
Change from base Build 1412842701: 0.2%
Covered Lines: 162
Relevant Lines: 167

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #17 (b9c5402) into main (dcda744) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   96.83%   97.00%   +0.17%     
==========================================
  Files           4        4              
  Lines         158      167       +9     
==========================================
+ Hits          153      162       +9     
  Misses          5        5              
Impacted Files Coverage Δ
src/utils.jl 100.00% <ø> (ø)
src/exact.jl 98.23% <100.00%> (+0.11%) ⬆️
src/distances/bures.jl 90.00% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcda744...b9c5402. Read the comment docs.

Copy link
Member

@davibarreira davibarreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@devmotion devmotion merged commit ada5933 into main Dec 21, 2021
@devmotion devmotion deleted the dw/discrete_uniform branch December 21, 2021 13:02
@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 1604615062

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 97.006%

Totals Coverage Status
Change from base Build 1412842701: 0.2%
Covered Lines: 162
Relevant Lines: 167

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants