Badge fix and CI Update #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zsunberg The tests were not passing when I made these updates. None of my changes should have affected this. It was failing testset "#23" which it looks like you put in for #23. I'm not sure why it started to fail this test now. However I think makes sense that it would throw a MethodError and not an ArgumentError. |
|
Thanks @dylan-asmar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed CI badge
Updated the CI workflow to separate documentation and tests. This helps with identifying test issues or documentation issues. It also allows for more restrictive use of running the documentation workflow based on tags associated with versions.
Updated the CI to include ubuntu, windows, and macOS.
Added
.vscodeto.gitignorefor vscode users.Cleaned up files associated with old travis ci runs.