Drop 0.4 support #284
Merged
Drop 0.4 support #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
musm
commented
May 10, 2017
src/BinDeps.jl
Outdated
|
|
||
| const dlext = Libdl.dlext | ||
| const shlib_ext = dlext # compatibility with older packages (e.g. ZMQ) |
There was a problem hiding this comment.
we should really update all the packages that still depend on this 3 year old definition
There was a problem hiding this comment.
Cairo and HttpParser, still use it
|
done |
|
I also submitted Prs to update Cairo.jl ,ZMQ.jl and HttpParser |
tkelman
reviewed
May 10, 2017
src/BinDeps.jl
Outdated
|
|
||
| # deprecations | ||
|
|
||
| @deprecate shlib_ext Libdl.dlext |
There was a problem hiding this comment.
should use the non-exporting version where possible
There was a problem hiding this comment.
This was wrong I forgot to push the fix, should be g2g now.
|
ci failures are unrelated, we are seeing JuliaPackaging/WinRPM.jl#104 |
tkelman
reviewed
May 12, 2017
| - JULIAVERSION: "julialang/bin/winnt/x86/0.5/julia-0.5-latest-win32.exe" | ||
| - JULIAVERSION: "julialang/bin/winnt/x64/0.5/julia-0.5-latest-win64.exe" | ||
| - JULIAVERSION: "julialang/bin/winnt/x86/0.5/julia-0.6-latest-win32.exe" | ||
| - JULIAVERSION: "julialang/bin/winnt/x64/0.5/julia-0.6-latest-win64.exe" |
|
this was in 0.5.0? |
|
Oops, I looked at version in the wrong place. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.