fix bin/startup_time.jl

JuliaPackaging · Oct 11, 2023 · bc5e987 · bc5e987
1 parent 3f540e3
commit bc5e987
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/bin/startup_time.jl b/bin/startup_time.jl
@@ -15,7 +15,8 @@ try
             end
         catch e
             if (isa(e, Base.IOError) && e.code == -Base.Libc.ECONNREFUSED) ||
-               (isa(e, HTTP.IOExtras.IOError) && e.e.code == -Base.Libc.ECONNREFUSED)
+                # TODO: Use ExceptionUnwrapping.jl documented API...
+               (isa(e, HTTP.ConnectError) && e.error.ex.code == -Base.Libc.ECONNREFUSED)
             else
                 @warn(e, typeof(e))
             end
@@ -34,4 +35,5 @@ try
     end
 finally
     kill(p)
+    wait(p)
 end
diff --git a/test/tests.jl b/test/tests.jl
@@ -11,6 +11,7 @@ function handle_http_error(e)
 
     # If it's a connection error, return the specific code, usually `ECONNREFUSED` or `EPIPE`
     if isa(e, HTTP.ConnectError)
+        # TODO: Use ExceptionUnwrapping.jl documented API...
         return e.error.ex.code
     end