Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more precompile and fix an inference problem #89

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 27, 2020

This shaves about 30100ms off the time to load a simple Requires-dependent package; not a ton, but pretty consistent and worth having given how many packages use Requires.

This does not eliminate all runtime inference when using Requires; get! simply refuses to completely precompile (probably JuliaLang/julia#32705?), although this helps. EDIT: fixed it by building it into the sysimage!

This shaves about 30ms off the time to load a simple Requires-dependent
package; not a ton, but pretty consistent and worth having given how
many packages use Requires.
timholy added a commit to JuliaLang/julia that referenced this pull request Aug 28, 2020
In conjunction with xref JuliaPackaging/Requires.jl#89,
this shaves about 100ms off the first usage of Requires.
@timholy
Copy link
Member Author

timholy commented Aug 28, 2020

Now even better with JuliaLang/julia#37256

@KristofferC
Copy link
Member

KristofferC commented Aug 28, 2020

Slightly related, but could it also be possible for the functions themselves that Requires creates from the @require macro to be put into a (anonymous?) module with lower optimization (perhaps even running interpreted). Ref JuliaLang/julia#37041.

timholy added a commit to JuliaLang/julia that referenced this pull request Aug 28, 2020
In conjunction with xref JuliaPackaging/Requires.jl#89,
this shaves about 100ms off the first usage of Requires.
@timholy timholy merged commit 0d560db into master Aug 28, 2020
@timholy timholy deleted the teh/precompile branch August 28, 2020 15:44
oscardssmith pushed a commit to oscardssmith/julia that referenced this pull request Aug 28, 2020
In conjunction with xref JuliaPackaging/Requires.jl#89,
this shaves about 100ms off the first usage of Requires.
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 29, 2020
In conjunction with xref JuliaPackaging/Requires.jl#89,
this shaves about 100ms off the first usage of Requires.
KristofferC pushed a commit that referenced this pull request Oct 28, 2021
Together with changes in Julia, this shaves about 100ms off the time to load
a simple Requires-dependent package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants