Update Singular, fix GMP dependency #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, sadly the required code (see #1682 (comment)) is not yet in there, so I'll mark this as a draft until it is. |
giordano
reviewed
Oct 3, 2020
|
Hmm, filtering out Windows / mingw builds doesn't work anymore? |
|
Yeah, you need platforms = filter!(p -> !Sys.iswindows(p), platforms) |
|
Aha, so all build scripts using |
|
Yeah.... |
|
However note that the |
Force GMP_jll to build with version 6.1.2, to ensure the resulting binaries work in both Julia <= 1.5 and >= 1.6
|
This works now |
|
Ok, let's see how this goes! |
|
For the record, there is a minor issues with the compat bounds: JuliaPackaging/BinaryBuilderBase.jl#45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force GMP_jll to build with version 6.1.2, to ensure the resulting
binaries work in both Julia <= 1.5 and >= 1.6
CC @staticfloat @thofma
If this works, we can next update PR #1695 similarly (CC @benlorenz).
Finally, I'd be tempted to apply this dependency patch to "all" JLLs using GMP_jll (with
[skip ci]) just to make sure we don't run into this issue again by accident, down the line. Or is that a bad idea for some reason?