Add ReadStat builder #247
Merged
Add ReadStat builder #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `gettext-dev` to enable `./autogen.sh`
* Add dependence on `zlib`
* Dodge pesky compiler warnings on GCC 8+
* Convince Windows to look in `${prefix}/include`
|
Awesome, thanks so much! I'll try to port ReadStat.jl ASAP to this :) Death to all build.jl files. |
|
The JLL package is probably currently broken though, because of JuliaPackaging/BinaryBuilder.jl#531 |
|
Tests locally all work for ReadStat.jl :) I get a warning: But that doesn't matter much. @staticfloat could you register ReadStat_jll? And then I can tag a new release of ReadStat.jl without a build.jl. |
|
Merged, and the warnings should be gone now as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need some help with this, so far I just copied the old build script we had in ReadStatBuilder over, but that doesn't seem to work anymore.