[PROJ] split julia versions for libcurl #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies the approach used in NetCDF_jll. This only contains the julia 1.3 build_tarballs, 1.6 will be in a follow up PR. And after PROJ, we need to do this for GDAL as well, using this as a dependency.
giordano
reviewed
Feb 14, 2021
P/PROJ/common.jl
Outdated
Comment on lines
25
to
29
| # sqlite needed to build proj.db, so this should not be the | ||
| # cross-compiled one since it needs to be executed on the host | ||
| apk add sqlite | ||
| # Get rid of target sqlite3, to avoid it's picked up by the build system | ||
| rm "${bindir}/sqlite3${exeext}" |
There was a problem hiding this comment.
This may be a good use case for HostBuildDependency!
visr
added a commit
to visr/Yggdrasil
that referenced
this pull request
Feb 15, 2021
Follow up of JuliaPackaging#2545.
giordano
added a commit
that referenced
this pull request
Feb 15, 2021
* [GDAL] split julia versions for libcurl Using the split PROJ version from #2545. * Update G/GDAL/common.jl Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
visr
added a commit
to JuliaGeo/Proj.jl
that referenced
this pull request
Feb 16, 2021
This is done to be able to provide builds that work across julia minor version, even if shipped libraries like libcurl update. Ref JuliaPackaging/Yggdrasil#2545 JuliaPackaging/Yggdrasil#2401
visr
added a commit
to JuliaGeo/Proj.jl
that referenced
this pull request
Feb 18, 2021
This is done to be able to provide builds that work across julia minor version, even if shipped libraries like libcurl update. Ref JuliaPackaging/Yggdrasil#2545 JuliaPackaging/Yggdrasil#2401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the approach used in NetCDF_jll. This only contains the julia 1.3 build_tarballs, 1.6 will be in a follow up PR.
And after PROJ, we need to do this for GDAL as well, using this as a dependency.