Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandoc-crossref #2667

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Add pandoc-crossref #2667

merged 3 commits into from
Mar 10, 2021

Conversation

rikhuijzer
Copy link
Contributor

@rikhuijzer rikhuijzer commented Mar 10, 2021

I would like to add pandoc-crossref. This version supports Pandoc version 2.9, which is contained in Yggdrasil at the moment.

After reading the documentation, I'm still unsure how to test the changes. Instead, I've used the Pandoc Yggdrasil script as a template. Some pointers on how I can improve the changes are welcome.

EDIT: I've got it working via the devcontainer. I am now fixing some issues in the file.

ArchiveSource("$url_prefix-Linux-$pandoc_ver.tar.xz", "57e8f71d46c401daf0a3247b7405b49503b836e93893730e6e5907f6cb2c0885"; unpack_target = "x86_64-linux-gnu"),
ArchiveSource("$url_prefix-macOS-$pandoc_ver.tar.xz", "b63ac830d7164279eb80041cd5f793e6b611ce1a701a86308ce5b2a3a99d33b2"; unpack_target = "x86_64-apple-darwin14"),
# Unknown archive format.
# ArchiveSource("$url_prefix-Windows-$pandoc_ver.7z", "3e943fcdd3f91951fe18f9900e136ccb9ea810b2582f4bd929760357eaf83ef4"; unpack_target = "x86_64-w64-mingw32"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be downloaded as

Suggested change
# ArchiveSource("$url_prefix-Windows-$pandoc_ver.7z", "3e943fcdd3f91951fe18f9900e136ccb9ea810b2582f4bd929760357eaf83ef4"; unpack_target = "x86_64-w64-mingw32"),
FileSource("$url_prefix-Windows-$pandoc_ver.7z", "3e943fcdd3f91951fe18f9900e136ccb9ea810b2582f4bd929760357eaf83ef4"; unpack_target = "x86_64-w64-mingw32"),

but you'll need to unpack it manually in the recipe with 7z

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check. I'll do that.

@rikhuijzer
Copy link
Contributor Author

Ok. I've tried to run the build locally via

So, I'm quite a bit stuck here. @giordano, what method do you use for building locally?

@giordano giordano merged commit 2df4e0f into JuliaPackaging:master Mar 10, 2021
@giordano
Copy link
Member

what method do you use for building locally?

Julia v1.6 built locally from the most the release branch (which BTW also includes the fix for hanging downloads). But I fixed the build recipe for you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants