Hotfix for p4est output routines on Windows #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hotfix for the different behavior of
fopen/ftellunder Windows, resolving the issue reported in cburstedde/p4est#113.I realize that it's frowned upon to create new builds for an already released version, but it's a blocking issue for us at the moment (preventing us to use
P4est_jllon Windows) and from what I can tell, no actual harm is done (it's not breaking any existing use ofP4est_jllsince the current version is unusable on Windows when trying to use the p4est output routines). Also, considering the past release frequency of the upstream project (approximately once every 2 years), I'd rather not wait for a proper patch release (at least in this particular case).