Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping to curl 7.78.0 #3575

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Bumping to curl 7.78.0 #3575

merged 4 commits into from
Sep 3, 2021

Conversation

bluesmoon
Copy link
Contributor

Bump version due to security issues in older versions of curl

@bluesmoon
Bumping to curl 7.78.0
0a7ebc9 
Bump version due to security issues in older versions of curl
@bluesmoon
update sha256 hash
62594fd
@Crghilardi
Copy link
Contributor

Looking through the release notes there was the addition of using libgsasl which doesn't seem to be available in Yggdrasil currently. If I am reading the configure script correctly it seems to be yes by default with a --disable-libgsasl flag added?

@bluesmoon
Copy link
Contributor Author

Thanks for the feedback. This is my first time doing anything with BinaryBuilder

@Crghilardi
Copy link
Contributor

Looks like there was another change that touched the configure file(curl/curl#7176) in the release as well.

It looks like the flag for metalink is set up to brute force error on anything containing the string metalink? We should be able to drop the entire --without-libmetalink from the flags now which is what they seem to do in all the updated CI scripts

@bluesmoon
Copy link
Contributor Author

@Crghilardi thank you for the help.

@vchuravy vchuravy requested a review from staticfloat September 3, 2021 10:20
@staticfloat
Copy link
Member

Note that this is only one part of the process; after building this, Julia will still continue to ship with an older version, and Julia itself needs to be updated to use newer stdlibs.

https://github.com/JuliaLang/julia/blob/master/deps/Versions.make#L29
https://github.com/JuliaLang/julia/blob/master/stdlib/LibCURL_jll/Project.toml#L3

@staticfloat staticfloat merged commit 5c8f5a6 into JuliaPackaging:master Sep 3, 2021
@bluesmoon bluesmoon deleted the patch-1 branch September 3, 2021 17:57
@bluesmoon bluesmoon mentioned this pull request Sep 3, 2021
Closed
@mkitti mkitti mentioned this pull request Jan 8, 2022
Merged
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
@bluesmoon @simeonschaub
Bumping to curl 7.78.0 (JuliaPackaging#3575)
8655443 
* Bumping to curl 7.78.0

Bump version due to security issues in older versions of curl

* update sha256 hash

* Disable libgasl which isn't in julia libs

* No longer need --without-libmetalink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluesmoon @Crghilardi @staticfloat