-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GDAL] Bump to v3.7.1 #7050
[GDAL] Bump to v3.7.1 #7050
Conversation
As I said already, it's more likely we want to update compat bounds. For example using HDF5 1.14 would be better, since we compile that one from source. |
Does this mean LibPQ needs to be rebuilt with v3.x OpenSSL? |
Yes: Yggdrasil/L/LibPQ/build_tarballs.jl Line 75 in 21d0e10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have a new GDAL build again, thanks for working on this. I see you also make progress in #7053.
Left some comments to include the latest changes.
Co-authored-by: Martijn Visser <mgvisser@gmail.com>
Co-authored-by: Martijn Visser <mgvisser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@giordano This should be ready to merge now. |
Dependency("GEOS_jll"; compat="~3.11"), | ||
Dependency("PROJ_jll"; compat="~900.100"), | ||
Dependency("GEOS_jll"; compat="3.11.2"), | ||
Dependency("PROJ_jll"; compat="901.300.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PROJ_jll above had a ~
compat specification. @visr what's the usual thing to do here with this package? Is ^
(the default) enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think this is fine. Since PROJ_jll has the 100x version_offset, I figured in #7366 it's easier to tag it as breaking using that, rather than forcing all dependencies to use ~
.
@@ -3,27 +3,26 @@ | |||
using BinaryBuilder, Pkg | |||
|
|||
name = "GDAL" | |||
upstream_version = v"3.6.2" | |||
version_offset = v"1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this in review, but this version offset should not have been set back to 0, since now the major version is v300, while the previous one was v301. Should we yank v300.700.200 from the registry and create a new v301 build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good, yeah
See JuliaPackaging#7050 (comment) Registration of the previous version was blocked: JuliaRegistries/General#91991
See #7050 (comment) Registration of the previous version was blocked: JuliaRegistries/General#91991
No description provided.