[Clipper2] Update from v1.0.4 to v1.2.2

[ferrolho]

No description provided.

[giordano]

Sounds like the shared library isn't built?

[ferrolho]

I tried running the BinaryBuilder.jl wizard locally, but I am getting the following error at the cmake stage:

sandbox:${WORKSPACE}/srcdir/Clipper2/CPP/build # cmake -DCMAKE_INSTALL_PREFIX=$prefix -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TARGET_TOOLCHAIN} -DCMAKE_BUILD_TYPE=Release -DCLIPPER2_TESTS=OFF -DCLIPPER2_EXAMPLES=OFF -DCLIPPER2_UTILS=OFF ..
Re-run cmake no build system arguments
CMake Error at /usr/share/cmake/Modules/Compiler/._ADSP-DetermineCompiler.cmake:1:
  Parse error.  Expected a command name, got bad character with text "".
Call Stack (most recent call first):
  /usr/share/cmake/Modules/CMakeCompilerIdDetection.cmake:6 (include)
  /usr/share/cmake/Modules/CMakeCompilerIdDetection.cmake:33 (_readFile)
  /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:282 (compiler_id_detection)
  /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:301 (CMAKE_DETERMINE_COMPILER_ID_WRITE)
  /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:6 (CMAKE_DETERMINE_COMPILER_ID_BUILD)
  /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:59 (__determine_compiler_id_test)
  /usr/share/cmake/Modules/CMakeDetermineCCompiler.cmake:123 (CMAKE_DETERMINE_COMPILER_ID)
  CMakeLists.txt:2 (project)


-- Configuring incomplete, errors occurred!
See also "/workspace/srcdir/Clipper2/CPP/build/CMakeFiles/CMakeOutput.log".

Also, I manually had to create the patch file locally within the Docker container. I wanted to add the bundled folder as a DirectorySource during the wizard setup, but I couldn't find a way to do it.

[ferrolho]

For completeness, the earlier issues were due to a missing SHARED keyword on an add_library instruction and also a stupid mistake from my part in which I was creating the patch file from a git diff w.r.t. the master branch of Clipper2 instead of w.r.t. the latest tagged version.

Special thanks to @giordano for the help during the very well known JuliaCon @ Boston Logan hackathon.