-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libjulia 1.12.0-DEV to latest master #9331
Conversation
There were several breaking kernel API changes
There is one api change in -JL_DLLEXPORT jl_binding_t *jl_get_binding_wr(jl_module_t *m JL_PROPAGATES_ROOT, jl_sym_t *var);
+JL_DLLEXPORT jl_binding_t *jl_get_binding_wr(jl_module_t *m JL_PROPAGATES_ROOT, jl_sym_t *var, int alloc); There are also some newly exported functions Various FreeBSD builds are failing with something similar to JuliaLang/julia#54533, so we might need 1.11 for x86_64 apple seems to hitting JuliaLang/julia#52067. 1.12 for apple fails with
which comes from JuliaLang/julia#55049 but this should be libunwind specific and not active for llvmunwind which we are using for apple? |
Thank you for the analysis @benlorenz, very helpful as always! I've updated to 1.11.0-rc3. I don't have time to look into the rest right now, maybe later or monday (of course everyone is welcome to push additional fixes in the meantime). |
I have added fixes for the freebsd issue and the llvmlibunwind issue. A PR for the unwind issue: JuliaLang/julia#55639 Not sure yet how to deal with the
|
Assuming non-windows and libunwind not disabled: The flag `-DLLVMLIBUNWIND` is currently set on macos only for `USE_SYSTEM_UNWIND=0` which seems wrong to me and causes build issues for macos on Yggdrasil in combination with the recent #55049 which should only affect gnu libunwind (`error: call to undeclared function 'unw_ensure_tls'`). This flag is now set independently of the system-libunwind flag (on Darwin and OpenBSD as before). `LIBUNWIND=-lunwind` is set for `USE_SYSTEM_UNWIND=0` || `USE_SYSTEM_UNWIND=1` && `OS != Darwin`. I don't think the check for Darwin make sense and might be a leftover from using osxunwind a (long) while ago. Changed that to always set `-lunwind` if enabled. x-ref: JuliaPackaging/Yggdrasil#9331
Seems to build now with my latest patch. @benlorenz could you please double check what I did? |
I don't know much about this but it seems reasonable from the discussion in that issue, we are now blocking the b16 instrinsic on x86_64 darwin. It falls back to the xmm code and the compiler seems happy with this. |
I guess we should also update the |
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Indeed (I could have sworn that I already updated Hmm, do we have any rules as to when we update the patch level vs. the minor version? I've now changed it to |
Assuming non-windows and libunwind not disabled: The flag `-DLLVMLIBUNWIND` is currently set on macos only for `USE_SYSTEM_UNWIND=0` which seems wrong to me and causes build issues for macos on Yggdrasil in combination with the recent #55049 which should only affect gnu libunwind (`error: call to undeclared function 'unw_ensure_tls'`). This flag is now set independently of the system-libunwind flag (on Darwin and OpenBSD as before). `LIBUNWIND=-lunwind` is set for `USE_SYSTEM_UNWIND=0` || `USE_SYSTEM_UNWIND=1` && `OS != Darwin`. I don't think the check for Darwin make sense and might be a leftover from using osxunwind a (long) while ago. Changed that to always set `-lunwind` if enabled. x-ref: JuliaPackaging/Yggdrasil#9331
There were several breaking kernel API changes
Will need this to update GAP related JLLs.
Perhaps we should also update 1.11 to rc3? Dunno if there were relevant changes.
CC @benlorenz