Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect Intel MPI in __init__ and print versionString when error occurs #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

detect Intel MPI in __init__ and print versionString when error occurs #64

wants to merge 1 commit into from

Conversation

AStupidBear
Copy link
Contributor

No description provided.

@andreasnoack
Copy link
Member

It looks like the code changes here don't match the PR title

@AStupidBear AStupidBear changed the title add intel mpi detect Intel MPI in __init__ May 25, 2020
@AStupidBear AStupidBear changed the title detect Intel MPI in __init__ detect Intel MPI in __init__ and print versionString when error occurs May 25, 2020
@AStupidBear
Copy link
Contributor Author

Is there any problem with this PR?

@bernstei
Copy link

I think you should probably add fixes to support Intel MPI in MPIType and MPIOp as well. Looks to me (from looking at, e.g. oneapi/mpi/2021.1.1/include/mpi.h) that Intel MPI uses the same numerical constant definitions as MPICH exactly, so you could just add :IntelMPI to the if clauses that currently match for MPICH3.

@Sideboard
Copy link

Intel MPI should be compatible with MPICH since they are part of the MPICH ABI Compatibility Initiative.

@bernstei bernstei mentioned this pull request May 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AStupidBear @andreasnoack @bernstei @Sideboard