make thread_sleeping definition a bit more robust #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
approved these changes
Oct 7, 2024
d-netto
force-pushed
the
dcn-change-thread-sleeping
branch
from
ac0fcaa
to
0b08ea7
Compare
Applied this change in the latest commit. Is bumping it from 3.1.2 to 3.1.3 correct here? Will we need to go through the process of registering this new version once this PR merges? |
|
Yep! I've added you to the repo so that you can do that. Once this merges, accept the commit, then leave the |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to use states such as 2, 3, 4, ... for other things in the profiler.
Let's be more specific about the fact that the
thread_sleepingstate corresponds to 1.See discussion in JuliaLang/julia#55889 (comment).