Enhance savefig() #494
Open
Enhance savefig() #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like windows tests fail due to kaleido 0.2 issue not related to PR. |
|
Thanks for the PR, I'll try to take a look soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
savefig(): combine docstring from all 3 versions, streamline keyword argument passing usingkwargs...plotlyjsandplotly_versionkeyword arguments tosavefig()to control which plotly.js Kaleido would be using to generate the figures.This is to allow using more recent versions of plotly.js than the one provided by the PlotlyJS.jl (the current one, 2.3.0, is more than a year old).
I have also regenerated the plotly.js artifact using version 2.35.2.
I can provide the file, or the maintainers can run
generate_artifacts.jlthemselves.See also comment for PlotlyBase.jl#106