Fixes for Julia 0.5 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was clarified in julia issue #17968 that when applying `map` on a dict, the function's return value should always be a Pair. When that's not true, don't use `map`.
|
That second issue has morphed into "don't call |
|
The travis error was fixed by JuliaLang/julia#17966, but that obviously hasn't made it to nightly yet. |
|
Thanks for doing this! |
|
And I'm happy my tests could expose bugs in base! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes deprecation warnings and errors with Julia 0.5. Getting the tests working was also the occasion for fixing two julia bugs, JuliaLang/julia#17966 and JuliaLang/julia#17968. This won't pass tests on 0.5 until those are backported, but the tests do pass for me locally.