-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FFMPEG.jl for video encoding #2099
Conversation
@ericphanson @daschw this should supercede #2095 - I've used FFMPEG.jl here and all the tests seem to be working, but there aren't any animation tests. I'll add some. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @asinghvi17 !
I don't think you need to add tests for animations. Firstly, they are covered by some of the test examples, I think e.g. number 2 and 30 or 31
Cool, thanks for the info @daschw! I put them there to make sure FFMPEG was working properly (which it isn't right now) but will change that shortly. The problem is in FFMPEG, I'll quickly change that to another API and revert back. |
Awesome! |
Perfect, it works now - I'll remove the check. |
Add FFMPEG.jl to Project.toml too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I think this closes #2030 |
Good catch, thanks! |
Thanks for this @asinghvi17! |
* add FFMPEG as a project dependency * run(`ffmpeg ...`) -> ffmpeg_exe(`...`) Add FFMPEG.jl to Project.toml too.
Use FFMPEG.jl for FFMPEG things.