Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FFMPEG.jl for video encoding #2099

Merged
merged 2 commits into from
Jul 13, 2019
Merged

Use FFMPEG.jl for video encoding #2099

merged 2 commits into from
Jul 13, 2019

Conversation

asinghvi17
Copy link
Member

Use FFMPEG.jl for FFMPEG things.

@asinghvi17
Copy link
Member Author

@ericphanson @daschw this should supercede #2095 - I've used FFMPEG.jl here and all the tests seem to be working, but there aren't any animation tests. I'll add some.

Copy link
Member

@daschw daschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @asinghvi17 !
I don't think you need to add tests for animations. Firstly, they are covered by some of the test examples, I think e.g. number 2 and 30 or 31

test/runtests.jl Outdated Show resolved Hide resolved
@asinghvi17
Copy link
Member Author

Cool, thanks for the info @daschw! I put them there to make sure FFMPEG was working properly (which it isn't right now) but will change that shortly. The problem is in FFMPEG, I'll quickly change that to another API and revert back.

@daschw
Copy link
Member

daschw commented Jul 13, 2019

Awesome!

@asinghvi17
Copy link
Member Author

Perfect, it works now - I'll remove the check.

@asinghvi17 asinghvi17 requested a review from daschw July 13, 2019 11:46
Add FFMPEG.jl to Project.toml too.
Copy link
Member

@daschw daschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@asinghvi17 asinghvi17 merged commit 8c2a66b into master Jul 13, 2019
@asinghvi17 asinghvi17 deleted the as/FFMPEG.jl branch July 13, 2019 12:28
@ericphanson
Copy link

I think this closes #2030

@asinghvi17
Copy link
Member Author

Good catch, thanks!

@logankilpatrick
Copy link

Thanks for this @asinghvi17!

daschw pushed a commit to daschw/Plots.jl that referenced this pull request Sep 8, 2019
* add FFMPEG as a project dependency

* run(`ffmpeg ...`) -> ffmpeg_exe(`...`)

Add FFMPEG.jl to Project.toml too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants