Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] Update precompiles #2835

Merged
merged 1 commit into from
Jul 1, 2020
Merged

[AUTO] Update precompiles #2835

merged 1 commit into from
Jul 1, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2020

Automated changes by create-pull-request GitHub action

@daschw daschw merged commit 698f9d8 into master Jul 1, 2020
@daschw
Copy link
Member

daschw commented Jul 1, 2020

On julia 1.4.2:
Current release:

julia> @time using Plots
 10.849055 seconds (23.34 M allocations: 1.206 GiB, 3.90% gc time)

julia> @time display(plot(rand(10)))
 13.588981 seconds (28.49 M allocations: 1.406 GiB, 3.64% gc time)

Now:

julia> @time using Plots
 10.036745 seconds (23.96 M allocations: 1.240 GiB, 3.97% gc time)

julia> @time display(plot(rand(10)))
 11.619033 seconds (12.34 M allocations: 611.958 MiB, 1.76% gc time)

@BeastyBlacksmith
Copy link
Member

what about 1.5?

@daschw
Copy link
Member

daschw commented Jul 1, 2020

will check later today

@timholy
Copy link
Contributor

timholy commented Jul 1, 2020

For me,

julia 1.4 (downloaded binary):

julia> @time using Plots; @time p = plot(rand(10)); @time display(p)
 10.592077 seconds (25.83 M allocations: 1.327 GiB, 4.69% gc time)
  3.981842 seconds (4.98 M allocations: 243.521 MiB, 1.94% gc time)
  6.818551 seconds (7.36 M allocations: 367.920 MiB, 1.43% gc time)

julia 1.5rc1 (built from source):

julia> @time using Plots; @time p = plot(rand(10)); @time display(p)
  7.181116 seconds (15.59 M allocations: 883.141 MiB, 3.48% gc time)
  2.843696 seconds (4.57 M allocations: 230.298 MiB, 2.56% gc time)
  4.355263 seconds (6.78 M allocations: 347.737 MiB, 2.23% gc time)

julia master with JuliaLang/julia#35877 (and the customization in JuliaLang/julia#35877 (comment)), JuliaLang/julia#36449, JuliaLang/julia#36452, and JuliaLang/julia#36459:

julia> @time using Plots; @time p = plot(rand(10)); @time display(p)
  5.503256 seconds (10.61 M allocations: 654.482 MiB, 4.07% gc time)
  2.660786 seconds (3.74 M allocations: 204.619 MiB, 2.43% gc time)
  4.071296 seconds (6.06 M allocations: 336.316 MiB, 2.41% gc time)

All three are Plots 1.5.1 and with Revise running in the background. (Without Revise, 1.4 is almost 2s faster in total; on 1.5 and nightly, Revise doesn't cause a performance hit.)

@BeastyBlacksmith BeastyBlacksmith deleted the SnoopCompile_AutoPR branch July 1, 2020 09:11
@timholy
Copy link
Contributor

timholy commented Jul 1, 2020

Inspired by #2782, for me here's 1.2 (which is Plots 1.4.4):

julia> @time using Plots; @time p = plot(rand(10)); @time display(p)
  7.298756 seconds (15.10 M allocations: 867.473 MiB, 6.12% gc time)
  2.944357 seconds (5.40 M allocations: 275.429 MiB, 3.80% gc time)
  8.641176 seconds (21.83 M allocations: 1.090 GiB, 5.30% gc time)

with Revise, and

julia> @time using Plots; @time p = plot(rand(10)); @time display(p)
  6.444962 seconds (12.18 M allocations: 719.997 MiB, 6.11% gc time)
  2.946809 seconds (5.08 M allocations: 259.969 MiB, 1.84% gc time)
  6.196895 seconds (8.80 M allocations: 449.288 MiB, 1.58% gc time)

without.

So nightly is by far the fastest yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants