Simplify build_layout logic

[t-bltg]

As per

Plots.jl/src/layouts.jl

Line 547 in 3f110d6

# TODO... much of the logic overlaps with the method above... can we merge?

.

[t-bltg]

I'm merging #3598, because JuliaPlots/PlotReferenceImages.jl#100 has been merged.

[t-bltg]

We hit JuliaStats/Distributions.jl#1358.

Fixed

[codecov]

Codecov Report

Merging #3609 (753df0e) into master (014b86a) will increase coverage by 1.44%.
The diff coverage is 76.13%.

❗ Current head 753df0e differs from pull request most recent head 5eb62ab. Consider uploading reports for the commit 5eb62ab to get more accurate results

@@            Coverage Diff             @@
##           master    #3609      +/-   ##
==========================================
+ Coverage   63.72%   65.16%   +1.44%     
==========================================
  Files          27       27              
  Lines        6566     6643      +77     
==========================================
+ Hits         4184     4329     +145     
+ Misses       2382     2314      -68     

Impacted Files	Coverage Δ
src/recipes.jl	58.09% <0.00%> (-0.57%)	⬇️
src/plot.jl	67.20% <7.40%> (-15.80%)	⬇️
src/animation.jl	38.20% <50.00%> (ø)
src/components.jl	61.89% <72.72%> (+5.18%)	⬆️
src/utils.jl	52.58% <84.61%> (+0.07%)	⬆️
src/backends/pgfplotsx.jl	60.94% <85.71%> (+1.61%)	⬆️
src/backends/gr.jl	89.00% <96.42%> (+1.48%)	⬆️
src/args.jl	72.92% <100.00%> (+0.46%)	⬆️
src/axes.jl	84.02% <100.00%> (+7.87%)	⬆️
src/examples.jl	61.76% <100.00%> (+0.57%)	⬆️
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f110d6...5eb62ab. Read the comment docs.

[BeastyBlacksmith]

Whats up with the benchmarks? Can you also re-enable the StatsPlots tests, if they are fixed?

[t-bltg]

Whats up with the benchmarks?

Which benchmarks ?

Can you also re-enable the StatsPlots tests, if they are fixed?

That won't work at the moment see the conditions listed at the tracker #3611.

@BeastyBlacksmith You're right, I think we can't reverse the fix now, CI passes in #3611.

[t-bltg]

@BeastyBlacksmith, could you explain to me in 2secs where the benchmark results can be seen ? (not handy to scroll the logs).
EDIT: the github-actions bot seems to post benchmark results on some branches only, is there a setting to make it post here for example ?

I'm not familiar with those: I believe they are used to measure performance regression somehow ? What is our policy for saying a benchmark is OK or not ?

[t-bltg]

Whats up with the benchmarks?

LGTM 💯

Results

ID	time ratio	memory ratio
["display"]	0.00 (5%) ✅	0.00 (1%) ✅
["load_plot_display"]	0.97 (5%)	0.00 (1%) ✅
["plot"]	0.72 (5%) ✅	1.00 (1%)