Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glvisualize backend #374

Merged
merged 3 commits into from
Sep 2, 2016
Merged

glvisualize backend #374

merged 3 commits into from
Sep 2, 2016

Conversation

SimonDanisch
Copy link
Member

Work in progress for the GLVisualize backend

tbreloff
tbreloff reviewed Aug 11, 2016
View reviewed changes
src/backends.jl
@@ -26,18 +26,18 @@ macro init_backend(s)
end)
end

@init_backend Immerse
@init_backend Gadfly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you commented these out?

@SimonDanisch
Copy link
Member Author

SimonDanisch commented Aug 16, 2016 •
edited
Loading

  • correct handling of all the different color attributs
  • text and labels
  • a few 3D plots still don't work perfectly
  • better camera for corner cases (extreme zoom values etc)
  • shape up shape plots
  • fix efficient renderloop (currently inefficient again, since there are weird artifacts otherwise)
  • fix line anti aliasing for all cases
  • make wireframe work for (x,y,z) surface plots

@tbreloff tbreloff mentioned this pull request Aug 19, 2016
Closed
@SimonDanisch
Copy link
Member Author

SimonDanisch commented Aug 21, 2016 •
edited
Loading

okay this starts looking okay!
Anyone daring to try this out should be on GLWindow, GLAbstraction, GLVisualize, FixedSizeArrays and GeometryTypes master!
New issues:

  • 2D camera can now rotate which is extremely annoying :D Restrict movement!
  • outline of sprites + barplots still not satisfactory
  • 3D axis
  • annotations
  • Reactive message queue fills up with long blocking loops without yield (e.g. @gif)

Here's a little (badly compressed) gif:
surf

It's embarrassing slow though, since GLVisualize and Plots build up the complete plot for every frame which is completely unnecessary! ;) Will need to figure out a API/hijack the existing one, to bypass this!

@SimonDanisch SimonDanisch changed the title glvisualize backend - do not merge glvisualize backend Aug 24, 2016
@SimonDanisch
Copy link
Member Author

can someone try this out?! :)

@SimonDanisch
Copy link
Member Author

gotta be on:
GLWindow, GLAbstraction, GLVisualize and GeometryTypes master and for FixedSizeArrays on:
SimonDanisch/FixedSizeArrays.jl#157

@SimonDanisch
Copy link
Member Author

Should we merge this?
And @tbreloff, could you add me as a collaborator, so that I can develop in a branch? It'll be easier to check out new versions of the backend like this!

@tbreloff
Copy link
Member

tbreloff commented Sep 1, 2016

We should, but I'm traveling right now. Did you rebase on a recent dev?

On Thursday, September 1, 2016, Simon notifications@github.com wrote:

Should we merge this?
And @tbreloff https://github.com/tbreloff, could you add me as a
collaborator, so that I can develop in a branch? It'll be easier to check
out new versions of the backend like this!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#374 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA492lCNLqZevCa6c61E8gU85II_zzWBks5qlt27gaJpZM4JFFlX
.

@tbreloff tbreloff merged commit 34135f8 into JuliaPlots:dev Sep 2, 2016
@tbreloff
Copy link
Member

tbreloff commented Sep 2, 2016

What a historic day... 🎉 🎉 🎉

tbreloff
tbreloff reviewed Sep 2, 2016
View reviewed changes
src/axes.jl
@@ -309,15 +309,13 @@ function expand_extrema!(sp::Subplot, d::KW)

# expand for bar_width
if d[:seriestype] == :bar
dsym = vert ? :x : :y
dsym = (!vert) ? :x : :y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reverted this change... any idea why you did this? The idea is that it's setting a default bar width and expanding the axis extrema. When the plot is vertical, we want to update the x axis.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it was skewed in the wrong direction so I changed this and then it was working...

@ablaom ablaom mentioned this pull request Apr 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonDanisch @tbreloff